bump armcompute v7 -> v8 in skewer/v2#36
Merged
Merged
Conversation
Migrate the v2 module from azure-sdk-for-go armcompute/v7 to armcompute/v8 (v8.1.0). Pure import-path bump; ResourceSKU and client types are unchanged between v7 and v8 (v8's only breaking change was Cloud Services classic removal, unused here). go mod tidy also moves azcore 1.19.1 -> 1.22.0. Build + tests pass.
There was a problem hiding this comment.
Pull request overview
Migrate the github.com/Azure/skewer/v2 module from azure-sdk-for-go armcompute/v7 to armcompute/v8 so downstream consumers on v8 can interoperate with skewer.SKU (which aliases armcompute.ResourceSKU).
Changes:
- Update all
armcomputeimports in v2 source, tests, example code, and the hack generator from/v7to/v8. - Bump v2 module dependencies to
armcompute/v8 v8.1.0(and related Azure SDK transitive updates viago mod tidy). - Refresh documentation snippet imports and module sums for the v2 module.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| v2/wrap.go | Switch armcompute import to /v8. |
| v2/sku.go | Switch armcompute import to /v8. |
| v2/sku_test.go | Switch armcompute import to /v8. |
| v2/README.md | Update example import to /v8. |
| v2/interface.go | Switch armcompute import to /v8. |
| v2/hack/generate_vmsize_testdata.go | Switch armcompute import to /v8 in generator. |
| v2/go.sum | Update sums after dependency bumps/tidy. |
| v2/go.mod | Require armcompute/v8 v8.1.0 and update Azure SDK versions. |
| v2/fakes_test.go | Switch armcompute import to /v8. |
| v2/example/example.go | Switch armcompute import to /v8. |
| v2/disk_test.go | Switch armcompute import to /v8. |
| v2/data_test.go | Switch armcompute import to /v8. |
| v2/clients.go | Switch armcompute import to /v8. |
| v2/cache_test.go | Switch armcompute import to /v8. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matthchr
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate the
v2module (github.com/Azure/skewer/v2) fromazure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v7toarmcompute/v8(v8.1.0).Why
Consumers (e.g. AKS RP) are moving to armcompute/v8. Because
skewer.SKUistype SKU armcompute.ResourceSKU, a consumer on v8 cannot convert itsarmcompute.ResourceSKUto skewer's v7-pinnedSKU. skewer needs a v8 release to unblock them.Changes
v2/: rewritearmcompute/v7->armcompute/v8imports across source, tests, example, and hack generator.v2/go.mod: requirearmcompute/v8 v8.1.0;go mod tidyalso moves azcore 1.19.1 -> 1.22.0.v2/README.md: update doc example import.Pure import-path bump — no API changes.
ResourceSKUand the client types are identical between v7 and v8 (v8's only breaking change was Cloud Services (classic) removal, which skewer does not use).Validation
go build ./...✅go test ./...✅ (all v2 tests pass)Suggest releasing as
v2.1.0(minor; no API change).